Conversation
dependencies in meta files accordingly
matusmartini
requested review from
climbfuji,
dustinswales,
grantfirl,
mdtoyNOAA and
rhaesung
as code owners
|
Is anyone still using this scheme? |
|
Pinging our primary GWD developer @mdtoyNOAA |
Thank you for checking @mdtoyNOAA. Do you know if this scheme still used at NOAA? |
|
It is still used in current operational models, including GFSv16, GEFSv12 etc. All upcoming implementations will not use this scheme anymore. |
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Fine with me.
I will note that we should probably refrain from manual formatting changes for now until we had a discussion among the ccpp-physics developers about adopting a Fortran coding style.
|
|
||
| dxres = pi2*arad/float(IMX) | ||
| hdxres = 0.5_kp*dxres | ||
| hdxres = 0.5*dxres |
There was a problem hiding this comment.
This change could result in bit-for-bit differences depending on compiler options.
There was a problem hiding this comment.
Although the other literal constants in this subroutine don't specify type, so this is more consistent.
6 participants
Description of Changes:
This PR does the following:
GWD/cires_ugwpv1_oro.F90(making comparison between v0 and v1 easier).GWD/ugwp_driver_v0.FtoGWD/ugwp_driver_v0.F90and update related meta files.con_g,con_omega, and remove unused old code.errflganderrmsg.Tests Conducted:
This PR does nothing, just cleanup. It gives bit-for-bit identical results in NEPTUNE.
Dependencies:
None.
Documentation:
None.